[FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

[Michael Niedermayer]

On Sat, Sep 03, 2016 at 12:06:39PM -0700, Sasi Inguva wrote:
> Hi Michael,
> 
> In fact from audacity I see that out-ingu.wav out-mp3.wav are almost
> equivalent,

They do not match. (and that is alot more vissible if you scale the
time axis up a bit)

You also dont use the existing API for handling initial padding/skip
And you didnt reply to this concern
its probably not that hard to fix that ...
instead of droping just at packet granularity you would set the stuff
for droping at sample granularity (too)


also maybe you missed my question about your oppinion on the correct
timestamp output:
"My first question is, entirely independant of the implementation from
 the patches. What is the correct output ? (my primary focus is on
 the timestamps)"

Iam curious because to me the timestamps of the dropped packets look
wrong and id like to know your oppinion about this. Is this a
implementation issue (if so please explain) or is there some reason
independant of the implementation  (if so please explain too)


[...]

> though not exactly. However if I do the same RAW->MOV->WAV
> conversion with head, I see that the out-head.wav is shifted to the right .

git master gets it totally wrong with mp3 in mov i agree here 100%

can you fix this exactly (not just almost)  ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160904/77b972ff/attachment.sig>