[FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

Greg Rowe growe at shoretel.com
Mon Oct 31 17:13:28 EET 2016

On 2016-10-18 2:20 PM, Michael Niedermayer wrote:
> On Tue, Oct 18, 2016 at 12:46:56PM -0400, Greg Rowe wrote:
>>> see
>>> libavfilter/asrc_sine.c
>>> this code should probably be reused / factored
>>> (note, any code moving/factoring of existing code should be in a
>>> seperate patch)
>> Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK to use
>> floating point for the generated tone or is it recommended to create
>> the tone and then convert it to double samples or some other
>> approach?
> can you write a fate test for the filter which is portable accross
> platforms ?
> every filter should ideally have a fate test.
> If you can write a working an portable fate test with float sine
> then i have no objections to it

Do you have ideas on how I could implement this feature while avoiding 
floating point (or at least to implemented the feature in a portable 
manner)?  I agree that it would be better but I'm not sure how to do it.

I could change the entire silence remove filter to avoid floating point 
ops but that would be a big change and I don't think that's a good idea.

Would it work if I created the tone using asrc_since.c and then 
converted that to double samples within the filter?  (rather than my 
existing approach which generates the tone as doubles using sin()).


Greg Rowe

More information about the ffmpeg-devel mailing list