[FFmpeg-devel] [PATCH] configure: make sure LTO does not optimize out the test functions
andreas.cadhalpun at googlemail.com
Wed Oct 26 22:36:19 EEST 2016
On 26.10.2016 10:52, Carl Eugen Hoyos wrote:
> 2016-10-26 1:16 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>> I'm under the impression that __attribute__((used)) is not available
>> for all compilers,
> Yes, but __attribute__((foo_bar)) does not break compilation here.
Have you tested with MSVC?
> (But it is still a regression: 3.1 should not have seen the patch,
> it doesn't support new incompatible external libraries, and the
> issue was neither a regression nor security-related.)
This was not about a new external library, the support was added in 2015
(commit 99eabcd), and I think fixing build failures is quite sensible
for release branches.
On 26.10.2016 10:55, Carl Eugen Hoyos wrote:
> 2016-10-26 1:35 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>> I forgot to include stdint.h. Fixed patch attached.
> Why don't you cast to (int)?
Because gcc doesn't like it:
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
More information about the ffmpeg-devel