[FFmpeg-devel] [PATCH] libavcodec/tests: Added test for libavcodec/avpacket.c

wm4 nfxjfg at googlemail.com
Wed Oct 26 15:00:46 EEST 2016


On Sat, 22 Oct 2016 23:40:42 -0700
Thomas Turner <thomastdt at googlemail.com> wrote:

> Function(s) Tested: av_packet_clone().
> 
> This test checks if av_packet_clone() can successfully make a copy of an AVPacket.
> Compares all data members in AVPacket EXCEPT for "buf" because "buf" is initialized
> to NIL in the original AVPacket [to be cloned].
> 
> This test also prints out the all the contents of the original and cloned AVPackets.
> 
> Signed-off-by: Thomas Turner <thomastdt at googlemail.com>
> ---

Am I the only one who thinks this test is overly complex and worthless?
(Checks if each field got copied... come on, that's not useful. And
would probably bitrot quickly as nobody would add new fields to the
test anyway.)


More information about the ffmpeg-devel mailing list