[FFmpeg-devel] [PATCH 01/12] adxdec: validate sample_rate

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Tue Oct 25 20:45:25 EEST 2016

On 25.10.2016 12:58, Paul B Mahol wrote:
> patch(es)have good intent, but better fix is doing/checking it in single place.

I don't agree.
In general, validity checks should be where the values are actually read.
This eliminates the risk that bogus values could cause problems between being set
and being checked.
Also, having only a check in a central place is bad for debugging, because it is
not immediately clear where the bogus value came from, when the check is triggered.
(I know this from personal experience debugging all the cases triggering the
assert in av_rescale_rnd.)

The problem with that approach is that such checks can easily be forgotten, which
is why I think a check in a central place would make sense in addition to checking
the individual cases.

Best regards,

More information about the ffmpeg-devel mailing list