[FFmpeg-devel] [PATCH] aiffdec: fix division by zero

Michael Niedermayer michael at niedermayer.cc
Thu Oct 20 03:56:41 EEST 2016

On Wed, Oct 19, 2016 at 09:18:51PM +0200, Andreas Cadhalpun wrote:
> This is similar to commit c143a9c.
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libavformat/aiffdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

can aiff work without block_align ?

either way, block_duration is from the header reading
if its still accurate then using it together with 1 instead of the
matching block align is quite likely not correct
OTOH if block_duration does not represent the actual content then
the duration would only be correct by pure chance

Its a bit unfortunate that theres no usecase with an undamaged sample
which would have clear correct values

one has to work on the assumptation of a use case where the user needs
to override the codec and then ask "what is correct to do" that makes
this a bit tricky ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161020/28f483ec/attachment.sig>

More information about the ffmpeg-devel mailing list