[FFmpeg-devel] [PATCH]nvenc: Add capability check for Temporal AQ
Sven C. Dack
sven.c.dack at sky.com
Wed Oct 19 17:09:27 EEST 2016
On 19/10/16 14:24, Hendrik Leppkes wrote:
> If its entirely untested (due to being unsupported), it should not be
> made available, and instead be added once it is supported and has been
> confirmed to be working properly.
> There is also no reason to add it if we know it doesn't work, it would
> just be misleading to add an option, which then shows up in the help
> output, if we already know it doesnt work anywhere (yet).
No, it's not. It's been tested and working. It allows users to test it's
availability in combination with hardware and libraries. It's even working when
the capability test says it isn't supported, in which case the encoder continues
to produce a valid output stream (this has been tested by me before I
implemented the availability test).
What it may not do is to meet your expectations in the output. Yet, temporal aq
can in fact produce an identical output in certain cases, which you shouldn't
have a problem with. It's also not misleading when in the absence of an
availability you then gets an error message informing you about the lack of support.
So I still don't see why you would want to object here. I personally see it as
being on the same level with the latest developments by Nvidia.
May I ask, are you strongly against it?
More information about the ffmpeg-devel