[FFmpeg-devel] comma at the end of enumerator lists

Michael Behrisch oss at behrisch.de
Mon Oct 17 01:11:08 EEST 2016

Am 16.10.2016 um 23:24 schrieb Clément Bœsch:
> On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote:
>> Hi all,
>> first of all thanks for providing this great library.
>> Today my pull request https://github.com/FFmpeg/FFmpeg/pull/237 has been
>> rejected which tried to remove the comma at the end of enumerator lists
>> which triggers a warning when compiling with gcc and -Wpedantic. I still
>> think it could be a good idea to remove this, especially in the cases
>> where the enumerator list already ends in some _NB item, which seems to
>> be the final one "forever", but I am here to learn :-).
> The enum with a final _NB (or similar) entry are the only ones where
> removing the comma is relevant.

So would a patch removing only those have a chance of being accepted?

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161017/b6fcaafb/attachment.sig>

More information about the ffmpeg-devel mailing list