[FFmpeg-devel] [PATCH] RTSP: pass TLS args for RTSPS

Jay jayridge at gmail.com
Sun Oct 16 16:43:24 EEST 2016

On Sat, Oct 15, 2016 at 10:44 PM Michael Niedermayer <michael at niedermayer.cc>

> On Sat, Oct 15, 2016 at 08:31:23PM +0000, Jay wrote:
> > Thank you for the feedback. I have been trying to get RTSPS cert
> validation
> > incorporated for several weeks. I would greatly appreciate someone on the
> > core team helping me guide this to completion. Please find your questions
> > answered below.
> >
> > > the get_file_handle extensions should be in a spererate patch than
> > > the rtsp changes
> >
> > I am process agnostic, but the RTSP changes are dependent on the TLS
> > changes. There is a check for peer addr in RTSP that is based on the file
> > descriptor.
> The TLS changes do not depend on the RTSP changes, they can be in a
> seperate patch, applied before. TLS and RTSP are seperate "modules"
> changes to them are cleaner if split

> >
> > > also is it safe for all to use the input file handle that way ?
> > > for example if one used a fifo the input state would not match the
> > > relevant output neccessarily
> >
> > I do not think the peer addr check is necessary. My goal is a minimal
> > patch, making RTSPS work with basic TLS options.
> Is that the only use of the file handle ?
I took another look. The peer addr is used later to setup output streams
and in the setup request. File handle is required for TLS+RTSP.

To fully answer the previous question, getpeername will not work on a fifo.
It will fail with ENOTSOCK. In practice this should not be a problem. Named
pipes are not supported by RTSP to my knowledge.

> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> Complexity theory is the science of finding the exact solution to an
> approximation. Benchmarking OTOH is finding an approximation of the exact
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

More information about the ffmpeg-devel mailing list