[FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

Nicolas George george at nsup.org
Sun Oct 16 11:58:14 EEST 2016

Le quartidi 24 vendémiaire, an CCXXV, James Almer a écrit :
> A missing DisplayUnit element or one with the default value of 0 means
> DisplayWidth and DisplayHeight should be interpreted as pixels.
> The current code setting st->sample_aspect_ratio is wrong when DisplayUnit
> is anything else.

Sorry to react after it was pushed, but: are you sure about the logic?
Naively, I think that a/b makes sense whatever the unit for a and b, as long
as it is known and the same: the logic should be applied for all units
except UNKNOWN. What am I missing?


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161016/3fef5ae9/attachment.sig>

More information about the ffmpeg-devel mailing list