[FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

Greg Rowe growe at shoretel.com
Fri Oct 14 21:09:51 EEST 2016


In the attached patch I've tried to make all of the changes you've pointed out.  I also renamed tone_hz to tone_frequency on Moritz Barsnick's suggestion.

Is there a good way to generate the tone while avoiding floating point operations?  If there is then don't bother reviewing this patch and I'll make that change once I know better how to do it.

I removed the unrelated changes.  The two parameters, tone_duration and tone_frequency, are integers now.  The tone_duration parameter is changed from seconds to milliseconds.  I have updated the documentation to reflect that.  I moved the tone generation to an initialization function and fill a buffer that exists for the duration of the filter instead of needlessly generating the tone on the fly.  


Greg Rowe

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-avfilter-af_silenceremove-add-optional-tone-when-sil.patch.txt
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161014/62ce4458/attachment.txt>

More information about the ffmpeg-devel mailing list