[FFmpeg-devel] [PATCH] libavcodec/mips/h264dsp_msa.c: fix type in some function parameters

Michael Niedermayer michael at niedermayer.cc
Thu Oct 13 20:14:42 EEST 2016

On Wed, Oct 12, 2016 at 04:09:40PM +0100, Vicente Olivert Riera wrote:
> This fixes a build problem for MIPS architecture that looks like this:
> libavcodec/mips/h264dsp_msa.c:2498:6: error: conflicting types for
> ‘ff_weight_h264_pixels16_8_msa’
>  void ff_weight_h264_pixels16_8_msa(uint8_t *src, int stride,
> This bug was introduced by commit bc26fe89275c267d169b468356c82ee59874407d:
>   avcodec/h264: Use ptrdiff_t for (bi)weight functions
> That commit changed the data type of some function parameters in some
> function definitions. However, the implementation of those functions in
> libavcodec/mips/h264dsp_msa.c wasn't changed accordingly.
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> ---
>  libavcodec/mips/h264dsp_msa.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161013/5b8cb007/attachment.sig>

More information about the ffmpeg-devel mailing list