[FFmpeg-devel] [PATCH] add hds demuxer

Nicolas George george at nsup.org
Thu Oct 13 12:27:12 EEST 2016

Le duodi 22 vendémiaire, an CCXXV, Steven Liu a écrit :
> init add hds demuxer
> Based-on: patch by CORY MCCARTHY <cory.mccarthy at shaw.ca>
> Based-on: patch by Gorilla Maguila <gorilla.maguila at gmail.com>
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>

Thanks for the update.

I think I already said it when it was first submitted: I am not really happy
about the use of libxml2. I remember a time when libxml2 was a "security
advisory of the week" kind of library, and looking at the changelog, it does
not seem to have progressed a lot since.

To be fair, implementing a full-featured XML parser is very hard work and

But really, almost nobody needs that, and especially not FFmpeg. What we
need is a parser capable of reading elements, attributes, text in three
standard encodings, and that is all. Implementing this should be reasonably
short work for a decent developer.

Of course, since I can not volunteer to do it myself soon, I will not
consider it grounds for rejecting the patch. But please consider it. If
libxml2 is enabled by default, that makes it a security concern; if it is
not, that gives this code much less usefulness and testing.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161013/0da04951/attachment.sig>

More information about the ffmpeg-devel mailing list