[FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

Ronald S. Bultje rsbultje at gmail.com
Mon Oct 10 17:17:15 EEST 2016


On Sun, Oct 9, 2016 at 7:32 AM, Steven Liu <lingjiujianke at gmail.com> wrote:

> 2016-09-16 15:07 GMT+08:00 Michael Niedermayer <michael at niedermayer.cc>:
> > On Thu, Sep 15, 2016 at 05:53:58PM -0800, Lou Logan wrote:
> > > On Wed, 7 Sep 2016 14:27:07 +0200, Michael Niedermayer wrote:
> > >
> > > > yes one can ignore it but its alot more usefull if people keep in
> > > > mind that theres patchwork.
> > >
> > > The patch submission checklist is lengthy.
> > >
> > > I'm fine with an addition somewhere in doc/developer pointing out that
> > > it exists and how to use it if the patch submitter wants to, but I
> don't
> > > think it needs to be in the checklist.
> >
> > where should it be put / where would you suggest to put it ?
> >
> I think this is very useful.
> Guys, what's the next step?

Put it somewhere that is not the checklist.

Checklist is a list of required checks and allows us to block patches not
adhering to it. For example, it mentions asan. If I send a patch that adds
an asan error, that is grounds for blocking the patch. I'm pretty sure we
unanimously agree that's a good thing.

Patchwork is not something a patch adheres to. Rather, it's a method of
patch tracking. As an analogy, trac is not a bug, or a bug report. Rather,
it's a method of tracking bugs and bug reports.

Aside from that linguistic difference, not all developers like patchwork
and/or want to use it, so adding it in a list of required steps seems wrong
to those developers that don't (want to) use it.

In conclusion, mentioning patchwork somewhere on our website or
documentation in the developer section is fine, but not in the checklist.
Maybe add it to section 1.6 (Submitting patches)?


More information about the ffmpeg-devel mailing list