[FFmpeg-devel] [PATCH]configure: Enable pie for toolchain=hardened.

Michael Niedermayer michael at niedermayer.cc
Tue Oct 4 19:00:16 EEST 2016


On Tue, Oct 04, 2016 at 12:24:00PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Sorry if I miss something but with this patch, the hardening_check 
> script succeeds here both for x86_32 and x86_64 (static and shared).
> 
> Please comment, Carl Eugen

only case i found that breaks is with --enable-libxavs
/usr/bin/ld: /usr/local/lib/libxavs.a(common.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
/usr/local/lib/libxavs.a: could not read symbols: Bad value

not sure our configure should detect this or if thats beyond its
scope

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161004/0dddf490/attachment.sig>


More information about the ffmpeg-devel mailing list