[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

Nicolas George george at nsup.org
Wed Nov 30 21:51:51 EET 2016

Le decadi 10 frimaire, an CCXXV, Vittorio Giovara a écrit :
> This is the value specified in the 23001-8_2013 document.

This looks paywalled. Please give links to public versions of specs in
that kind of case.

But I am pretty sure this document does not specify the values of enums
in FFmpeg's API. If the rest of the code requires that the values of the
enum match values in files or protocol, then I think a comment must say
so clearly. And if not, then the gap is not needed.

> Hm those should probably be addressed too, the decoder and filters
> ones are simple, while static options might be tricky.

My opinion on the matter is that any such kind of enumeration should
include not only the enum, but also a value->string function (this was
done), a string->value function and an AV_OPT type. That requires a
little work, though.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161130/ed54bc6f/attachment.sig>

More information about the ffmpeg-devel mailing list