[FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Nov 29 01:09:55 EET 2016

2016-11-28 23:25 GMT+01:00 Gregory J. Wolfe <gregory.wolfe at kodakalaris.com>:

> This patch sets the required libopenh264 data structures using
> the FFmpeg colorspace information so that video players will
> know how to properly decode video files created using FFmpeg
> and libopenh264.

Please copy FFmpeg's switch() style from another file and please
consider to align "param.", "=" and "break".

> +    param.sSpatialLayers[0].uiVideoFormat = VF_UNDEF;

(What are the possible "formats"?)

> +    param.sSpatialLayers[0].bFullRange = (avctx->color_range == AVCOL_RANGE_JPEG);

The parentheses look unneeded.

Carl Eugen

More information about the ffmpeg-devel mailing list