[FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.
andreas.cadhalpun at googlemail.com
Mon Nov 28 22:49:51 EET 2016
On 28.11.2016 11:48, Nicolas George wrote:
> L'octidi 8 frimaire, an CCXXV, Andreas Cadhalpun a écrit :
>> I'm not sure I understand. Just do the rebase once, commit the deprecation
>> to git master and happily work on the other changes.
> Except that kind of patch requires at least three rounds of review.
> Wasted time.
>> Not if the deprecation gets added, and thus this ifdeffery in avfilter.h
>> is reduced to a temporary problem.
> With the provisions I added in the current patch, the only drawbacks
> that remains are matter of elegance and minor convenience. That means it
> is no matter if it stays that way a long time. Therefore, no need to
> revert (urgh, you really like wasting your time!
Rather the contrary, which is why I would prefer if the deprecation could
be applied first. However, I've no intention of wasting your time, either. ;)
So if it works better for you the other way around, I'm OK with that as well.
> reverting that big a patch!) even if the deprecation only reaches the
> repository after the release.
I'd rather not have a release that adds this ifdeffery to the public ABI
without deprecating direct use of the struct, though.
More information about the ffmpeg-devel