[FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Mon Nov 28 01:20:12 EET 2016


On 28.11.2016 00:11, Nicolas George wrote:
> L'octidi 8 frimaire, an CCXXV, Andreas Cadhalpun a écrit :
>> How would it conflict with this patch?
>> Unless I misunderstood something the deprecation should only affect the
>> public API, while this change should only affect the internal parts,
>> so the only possible conflict could be in avfilter.h, where it would be
>> easy to resolve.
> 
> Making the structure opaque involves moving its definition from the
> public header to a private one (first copying then removing after the
> deprecation delay). Including the lines that deal with the new internal
> fields.
> 
> A patch that adds lines and a patch that moves the surrounding code
> conflict, there is no way about it.

Sure, but that conflict should be easy to resolve.

Anyway, I'm not really thrilled by the idea of doing the deprecation
afterwards, but if you do it soon, it shouldn't be a problem in practice.

Worst case would be that if the deprecation isn't added before the next
release, this patch would need to be reverted.

Best regards,
Andreas


More information about the ffmpeg-devel mailing list