[FFmpeg-devel] [PATCH] avcodec/aac_adtstoasc: recover original extradata if the stream is already ASC

Hendrik Leppkes h.leppkes at gmail.com
Fri Nov 25 01:13:21 EET 2016


On Tue, Nov 22, 2016 at 3:13 AM, James Almer <jamrial at gmail.com> wrote:
> Fixes ticket #5973
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Maybe init() should propagate the extradata down the filter chain instead
> of this, since if an aac stream has extradata then it means that it's an
> ASC stream. Neither ADTS or LATM use extradata.
>
> What's preferred?
>

Forwarding the extradata right away in init is probably better. As you
say any of the other alternatives don't use any.
Could try to parse it to make sure its valid, and not forwarding
garbage, if you really care.

- Hendrik


More information about the ffmpeg-devel mailing list