[FFmpeg-devel] [PATCH] mpegpicture: use coded_width/coded_height to allocate frame

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Fri Nov 25 01:03:30 EET 2016

On 24.11.2016 17:57, Michael Niedermayer wrote:
> On Thu, Nov 24, 2016 at 05:45:38PM +0100, Michael Niedermayer wrote:
>> Is it correct that your cases uses
>> decode_wmv9() -> vc1_decode_i_blocks() ?


>> these decode a rectangele up to end_mb_y, end_mb_x
>> does this mismatch with what later code accesses ?

Yes, s->mb_width and s->mb_height are different from
v->end_mb_x and s->end_mb_y.

>> would using end_mb_* in the EC code fix this ?

I'm not sure how this could be done properly, simply setting
s->mb_width and s->mb_height to the other values does not work.

>> (or disabling EC if they mismatch)
> Note, for this sadly end_mb_* in MSS2 would need to be treated
> differently than other codecs as it has different semantics
> disabling EC on end_mb_ mismatch might be easier

Disabling error correction in that case works, though.
Attached is a patch for that.

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mss2-only-use-error-correction-for-matching-block-co.patch
Type: text/x-diff
Size: 1605 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161125/0ad925b6/attachment.patch>

More information about the ffmpeg-devel mailing list