[FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Nov 22 02:27:04 EET 2016


2016-11-22 0:40 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:

> For example what should be done about overflows, e.g. when
> calculating the bit rate? Does this count as demuxer failing?

I don't understand this question:
There are formats for which we don't know the specification (or
it may not exist): Of course we always want to fix all undefined
behaviour, all crashes and similar - this is not related to the
specifications in question.

FFmpeg should never by default refuse to decode media files
that can be decoded and it should never stop reading such files.

> And what should be done if the spec says a field is unsigned,
> but our framework only supports the signed variant?

Is there a sample for which this makes a difference? If yes, we
should try to fix it.

Carl Eugen


More information about the ffmpeg-devel mailing list