[FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Nov 20 01:37:05 EET 2016

On 19.11.2016 22:36, Michael Niedermayer wrote:
> On Sat, Nov 19, 2016 at 05:30:59PM +0100, Andreas Cadhalpun wrote:
>> A hard failure is unnecessary and Carl Eugen [1] and Hendrik [2]
>> convinced me that it should be avoided.
> I think there are 2 different things here
> unavailable data, like a bitrate of 0
> and
> wrong data like a negative bitrate
> We do not accept wrong values in general,

If you say so. I'm more interested in fixing the crash than continuing
this discussion, so I changed it to always error out. See attached patch.

> ffm files are AFAIK generally temporary (on disk fifo) files generated
> by the current muxer.

If that's the case, why does the demuxer still support FFM1 even though
the muxer can't create such files anymore?

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ffmdec-validate-codec-parameters.patch
Type: text/x-diff
Size: 7059 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161120/f3638fe2/attachment.patch>

More information about the ffmpeg-devel mailing list