[FFmpeg-devel] [PATCH 1/2] vc1dec: support multiple slices in frame coded images with hwaccel

Michael Niedermayer michael at niedermayer.cc
Fri Nov 18 19:40:01 EET 2016

On Fri, Nov 18, 2016 at 03:18:27PM +0100, Hendrik Leppkes wrote:
> On Fri, Nov 18, 2016 at 3:11 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> > Based on a patch by Jun Zhao <mypopydev at gmail.com>
> > ---
> >  libavcodec/vc1dec.c | 41 +++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 39 insertions(+), 2 deletions(-)
> >
> As a quick run down on the whole set:
> - This does fix decoding of frame-coded samples (ie. fate-vc1_sa10091
> and fate-vc1_sa20021) on NVIDIA using DXVA2, no regressions using
> DXVA2 are known
> - This does fix decoding of these samples on Intel GPUs using VAAPI,
> however it appears to break on AMD using VAAPI. Important to note here
> however is that this change is matching up with the vaapi spec, and
> the AMD implementation is more or less hacky.
> - VDPAU seems to overall be unimpressed and keeps working as before.
> I hope I summarized the non-DXVA2 cases properly, as I didn't test
> those personally, but relied on data from Mark Thompson.
> Despite the breakage of AMD VAAPI decoding, this change appears to be
> correct in the sense that it matches the VAAPI and DXVA2 specs on how
> to handle slices and fixes decoding on two different GPUs, using those
> two APIs.

can the amd case be detected and the implementation adapted so
everything works ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161118/5cd98e8a/attachment.sig>

More information about the ffmpeg-devel mailing list