[FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

Matthew Gregan kinetik at flim.org
Fri Nov 18 05:25:09 EET 2016


At 2016-11-17T22:57:49-0300, James Almer wrote:
> > @@ -345,6 +346,7 @@ const AVCodecTag ff_codec_movaudio_tags[] = {
> > +    { AV_CODEC_ID_FLAC,            MKTAG('f', 'L', 'a', 'C') }, /* nonstandard */
> 
> This is enables muxing into mov, which bypasses the experimental check below
> since mov isn't MODE_MP4.

Thanks.  Updated the check to reject non-MP4 as invalid before checking the
experimental flag.  I based the original check on the VP9/MP4 muxing, which
has the same bug, should I send a patch to restrict that to MP4 too?

Updated patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-experimental-muxing-support-for-FLAC-in-ISO-BMFF.patch
Type: text/x-diff
Size: 6345 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161118/7c450299/attachment.patch>


More information about the ffmpeg-devel mailing list