[FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

[Kyle Swanson]

On Thu, Nov 17, 2016 at 6:55 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Thu, Nov 17, 2016 at 11:04:46AM -0600, Kyle Swanson wrote:
>> Hi,
>>
>> Here's a couple of patches which update the ebur128 filter to use the
>> recently added ebur128 API. This updated filter allows fine-tuned
>> control over which EBU R128 parameters are measured, and provides
>> modest speed increases over the previous ebur128 filter. Also
>> noteworthy: this removes the video output option of the ebur128
>> filter. This is extraneous for an ebur128 measurement filter IMHO, but
>> if we wanted to keep similar functionality in FFmpeg, we'd be better
>> served by a new video source filter where custom meters could be
>> created via exported frame metadata.
>>
>> The first patch adds true peak functionality to the ebur128 API using
>> swresample (this was already discussed a little bit:
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2016-November/202583.html)
>> The second patch is an update to the ebur128 filter.
>>
>> Kyle
>
> src/libavfilter/af_ebur128.c: In function ‘write_strings’:
> src/libavfilter/af_ebur128.c:121:9: error: variable length array ‘sample_peak’ is used [-Werror=vla]
> src/libavfilter/af_ebur128.c:133:9: error: variable length array ‘true_peak’ is used [-Werror=vla]

Thanks. Didn't realize this wasn't allowed. Easy fix.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If you think the mosad wants you dead since a long time then you are either
> wrong or dead since a long time.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>