[FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

Vittorio Giovara vittorio.giovara at gmail.com
Thu Nov 17 23:06:32 EET 2016


On Thu, Nov 17, 2016 at 3:58 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Thu, Nov 17, 2016 at 3:53 PM, Vittorio Giovara
> <vittorio.giovara at gmail.com> wrote:
>>
>> This prevents writing past bounds.
>>
>> Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
>> ---
>> Any opinions about this?
>
>
> Hm... I agree right now it's probably broken, but I'd argue that we should
> fix it, not forbid it.
>
> That may be out of scope for you, but then at least don't remove the FIXME
> in the TODO list, and output AVERROR_PATCHWELCOME?

sure, as you prefer

> But maybe I'm thinking about this too much/idealistically...

:)
-- 
Vittorio


More information about the ffmpeg-devel mailing list