[FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

Nicolas George george at nsup.org
Thu Nov 17 18:27:15 EET 2016


Le quartidi 24 brumaire, an CCXXV, Andreas Cadhalpun a écrit :
> It might work at first by accident and then some change in the internal
> API could cause problems.
> If the API usage is wrong, it should fail at build-time and not introduce
> grave security vulnerabilities at run-time.

That would be best, indeed. But sometimes you have to do with the
limitations of the language and tools and choose the lesser of two
evils.

> API changes in libavfilter are less of a problem, since not that many
> programs use it. For example, the codecpar change has orders of magnitude
> more impact.

I mostly agree. If people are ok with a sudden API change in lavfi, then
I can rework my patch for that. But I want confirmation beforehand.

A scheduled API change would be better, but I do not want to wait for it
to apply the patch, so you would have to accept a temporary solution.

> However, ideally any incompatible API change should be coordinated with Libav.

I have been spurned in the past in my attempts to coordinate lavfi
evolution with libav, I will not make efforts again for that.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161117/dc5837f7/attachment.sig>


More information about the ffmpeg-devel mailing list