[FFmpeg-devel] [PATCH] avformat/mpeg: Adjust vid probe threshold to correct mis-detection

Michael Niedermayer michael at niedermayer.cc
Wed Nov 16 02:34:36 EET 2016


On Tue, Nov 15, 2016 at 09:12:43PM +0100, wm4 wrote:
> On Tue, 15 Nov 2016 20:06:42 +0100
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > Fixes: _ij.mp3
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/mpeg.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
> > index 1c441c5..423877e 100644
> > --- a/libavformat/mpeg.c
> > +++ b/libavformat/mpeg.c
> > @@ -112,7 +112,7 @@ static int mpegps_probe(AVProbeData *p)
> >                            : AVPROBE_SCORE_EXTENSION / 2; // 1 more than .mpg
> >      if ((!!vid ^ !!audio) && (audio > 4 || vid > 1) && !sys &&
> >          !pspack && p->buf_size > 2048 && vid + audio > invalid) /* PES stream */
> > -        return (audio > 12 || vid > 3 + 2 * invalid) ? AVPROBE_SCORE_EXTENSION + 2
> > +        return (audio > 12 || vid > 6 + 2 * invalid) ? AVPROBE_SCORE_EXTENSION + 2
> >                                                       : AVPROBE_SCORE_EXTENSION / 2;
> >  
> >      // 02-Penguin.flac has sys:0 priv1:0 pspack:0 vid:0 audio:1
> 
> Works for me (I reported this, so same test sample). But I'm not
> convinced whether it's the right solution.

I posted the patch to find out if someone has a better solution.


> Not opposed to applying it
> either since it at least makes the bogus heuristic return better
> results.

s/bogus// and theres nothing i disagree with

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161116/e1d7ed04/attachment.sig>


More information about the ffmpeg-devel mailing list