[FFmpeg-devel] [PATCH] avcodec/libx264: fix forced_idr logic

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Nov 14 15:50:00 EET 2016


On 11/11/2016 4:01 PM, Timo Rothenpieler wrote:
> -1 and 0 both mean false now, and I left in the option to pass -1 to
> stay compatible with possible 3rd parties who pass it.

Well that's certainly non-obvious...

> So changing to default to 0 doesn't really matter, and I decided to keep
> the patch minimal.
> Changing to default to 0 would be fine as well.

This patch LGTM if you push a 2nd patch with it that changes the default to 0.

- Derek


More information about the ffmpeg-devel mailing list