[FFmpeg-devel] [PATCH 2/9] arm: Clear the gp register alias at the end of functions

Ronald S. Bultje rsbultje at gmail.com
Mon Nov 14 15:01:41 EET 2016


assume this is my reply on all patches in the range 2-9:

On Mon, Nov 14, 2016 at 5:32 AM, Martin Storsjö <martin at martin.st> wrote:

> We reset .Lpic_gp to zero at the start of each function, which means
> that the logic within movrelx for clearing gp when necessary will
> be missed.
> This fixes using movrelx in different functions with a different
> helper register.
> This is cherry-picked from libav commit
> 824e8c284054f323f854892d1b4739239ed1fdc7.
> ---
>  libavutil/arm/asm.S | 3 +++
>  1 file changed, 3 insertions(+)

I have no idea about any of this stuff, so I can't give a proper technical

I've followed review by actually knowledgeable people on these patches on
libav-devel and I think they have been sufficiently reviewed, so I'll push
this whole set tomorrow unless people object.


More information about the ffmpeg-devel mailing list