[FFmpeg-devel] [PATCH] avcodec/libx264: fix forced_idr logic

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Nov 11 17:28:46 EET 2016

On 11/11/2016 3:26 PM, Derek Buitenhuis wrote:
> This patch LGTM.
> When I added this option in c981b1145a857c8f962c93b8eecb1c613b20ffe9, the type was
> INT, and the default was -1, and it was correct. It was later broken in
> fb99ef0bd39a1859d0e65c6c16caa8e17dd3cfbe. I suggest looking at everything touched
> in fb99ef0bd39a1859d0e65c6c16caa8e17dd3cfbe to make sure nothing else was similarily
> broken.

Actually, looking closer, the default is still -1.

Thus either this patch us incorrect, or the default should be changed to be 0.

- Derek

More information about the ffmpeg-devel mailing list