[FFmpeg-devel] [PATCH] vp9: add avx2 iadst16 implementations.

Ronald S. Bultje rsbultje at gmail.com
Wed Nov 9 02:13:39 EET 2016


Hi,

On Tue, Nov 8, 2016 at 6:33 PM, compn <tempn at mi.rr.com> wrote:

> On Tue, 8 Nov 2016 14:44:32 -0500
> "Ronald S. Bultje" <rsbultje at gmail.com> wrote:
>
> > >> x86-32 linux gets stomach ache from this:
> > >>
> > >> YASM    libavcodec/x86/vp9itxfm.o
> > >> src/libavcodec/x86/vp9itxfm.asm:2150: error: instruction expected
> > >> after label
> > >> src/libavcodec/x86/vp9itxfm.asm:2151: error: instruction expected
> > >> after label
> > >> src/libavcodec/x86/vp9itxfm.asm:2152: error: instruction expected
> > >> after label
> > >
> > >
> > > Ah right, yes this is meant to be for 64bit only. I'll add some
> > > #if/%if around it...
> > >
> >
> > They were already there but one %endif was misplaced. Fixed locally.
>
> is nice to resend patch just so "we" (by we i mean michael) can keep
> checking for problems like this ;)
>
> unless you already tested on x86...


Yes, I re-tested on x86-32, problem is gone now.

Ronald


More information about the ffmpeg-devel mailing list