[FFmpeg-devel] [PATCH] ffmpeg: Fix bsf corrupting merged side data

[Michael Niedermayer]

On Thu, Nov 03, 2016 at 11:17:05AM -0300, James Almer wrote:
> On 11/3/2016 10:55 AM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  ffmpeg.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 3b91710..6b7ce72 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -789,6 +789,7 @@ static void output_packet(OutputFile *of, AVPacket *pkt, OutputStream *ost)
> >      if (ost->nb_bitstream_filters) {
> >          int idx;
> >  
> > +        av_packet_split_side_data(pkt);
> >          ret = av_bsf_send_packet(ost->bsf_ctx[0], pkt);
> >          if (ret < 0)
> >              goto finish;
> > 
> 
> Is there a testcase this fixes that can be turned into a FATE test?

I had a rtmp stream someone setup for debuging this that failed with
stream copy but storing it to disk didnt result in a reproduceable
testcase

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161103/e7074431/attachment.sig>