[FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

Derek Buitenhuis derek.buitenhuis at gmail.com
Thu Nov 3 00:50:34 EET 2016


On 10/26/2016 7:31 PM, Sasi Inguva wrote:
> According to spec ISO_IEC_15444_12 "For any media stream for which no segment index is present, referred to as non‐indexed stream, the media stream associated with the first Segment Index box in the segment serves as a reference stream in a sense that it also describes the subsegments for any non‐indexed media stream."
> 
> Signed-off-by: Sasi Inguva <isasi at google.com>
> ---
>  libavformat/isom.h |  1 +
>  libavformat/mov.c  | 25 ++++++++++++++++++++++---
>  2 files changed, 23 insertions(+), 3 deletions(-)

The idea seems to sound OK.

[...]

> st->duration = sc->track_end = av_rescale(ref_st->duration, sc->time_scale, ref_sc->time_scale);

Without surrounding context, this line seems a bit funky. You're intending
to set the duration/end to ... timescale? One second?

- Derek


More information about the ffmpeg-devel mailing list