[FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

Matthew Gregan kinetik at flim.org
Wed Nov 2 01:21:52 EET 2016

At 2016-11-01T00:56:45-0300, James Almer wrote:
> The muxer gets the extradata as created by the encoder only during init().
> Even if the encoder changes it in any way afterwards, it will never make
> it to the muxer. That's why packet side data is used for this.
> The reason the encoder used the AVCodecContext extradata to store the
> updated Streaminfo before creating the packet side data is most likely
> because it was an already allocated buffer. Technically, it's not the
> "proper" thing to do, but it also doesn't seem to make a difference.

Makes sense, thanks for the explanation.

Updated patch attached with the following changes:
- Uses libavcodec/flac.h for the FLAC_STREAMINFO_SIZE and
  FLAC_METADATA_TYPE_STREAMINFO definitions, per the feedback on the demuxer
- Fixes the sample size in bits written to the 'fLaC' audio box.
  Thanks to Vittorio Giovara for pointing this out.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-experimental-muxing-support-for-FLAC-in-ISO-BMFF.patch
Type: text/x-diff
Size: 6420 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161102/f1447f06/attachment.patch>

More information about the ffmpeg-devel mailing list