[FFmpeg-devel] [PATCH 2/3] avcodec/aacenc_is: Assert that minthr is not 0.0, this would lead to division by 0 later

[Claudio Freire]

On Mon, May 16, 2016 at 4:10 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> yes,
>
> with the patch fate fails:
>
> Test aac-pred-encode failed. Look at tests/data/fate/aac-pred-encode.err for details.
> make: *** [fate-aac-pred-encode] Error 134
>
>
>>
>> A threshold of 0 would in theory cause a zeroed band (zeroes[i] == 1),
>> and those should be skipped.
>>
>> I think the proper fix would be figuring out why those aren't being
>> skipped, if that is the case.
>
> i never meant this patch to be a proper fix, more a bug report ...

I think I see the problem, the code is measuring minthr on a
per-window basis when it should be on a per-window-group basis.

I'll test some fixes soon, time permitting.