[FFmpeg-devel] [PATCH] Const src in av_packet_clone declaration

[wm4]

On Thu, 12 May 2016 16:02:48 +0300
Andriy Lysnevych <andriy.lysnevych at gmail.com> wrote:

> ---
>  libavcodec/avcodec.h  | 2 +-
>  libavcodec/avpacket.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 97b2128..1ad0412 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -4300,7 +4300,7 @@ AVPacket *av_packet_alloc(void);
>   * @see av_packet_alloc
>   * @see av_packet_ref
>   */
> -AVPacket *av_packet_clone(AVPacket *src);
> +AVPacket *av_packet_clone(const AVPacket *src);
> 
>  /**
>   * Free the packet, if the packet is reference counted, it will be
> diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
> index 9cdfafd..dd8b71e 100644
> --- a/libavcodec/avpacket.c
> +++ b/libavcodec/avpacket.c
> @@ -584,7 +584,7 @@ fail:
>      return ret;
>  }
> 
> -AVPacket *av_packet_clone(AVPacket *src)
> +AVPacket *av_packet_clone(const AVPacket *src)
>  {
>      AVPacket *ret = av_packet_alloc();
> 

That's a change that could break source-compatibility with C++, I don't
think it can be made so easily.