[FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

Michael Niedermayer michael at niedermayer.cc
Wed May 4 02:29:58 CEST 2016


On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote:
> I have no idea why the first hunk uses ost->enc_ctx, because as far as
> I understand, that is never used in case of -c:v copy, but this code
> block is only entered if encoding_needed=0, which means stream_copy=1.

when the code was added it was followed by a
ret = avcodec_copy_context(ost->st->codec, ost->enc_ctx);
later that was removed


do you have a testcase for which this hunk makes a differnce?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160504/8f13d9ea/attachment.sig>


More information about the ffmpeg-devel mailing list