[FFmpeg-devel] [PATCH 1/2] vc2enc: prevent random data

Christophe Gisquet christophe.gisquet at gmail.com
Tue May 3 22:40:55 CEST 2016


Le 3 mai 2016 22:15, "Rostislav Pehlivanov" <atomnuker at gmail.com> a écrit :
>
> On 3 May 2016 at 19:16, Christophe Gisquet <christophe.gisquet at gmail.com>
> wrote:
> >
> >
> > Btw, afaik, the padding is 0xFF, so expecting 0 in the buffer there
> > can't do the job.
> >
> >
> I don't get it, you keep saying that the padding must be 0xff yet the
patch
> you posted puts 0x00.

Didn't a second mail and patch reach the mailing list?

> Where did you even read that the padding must be
> 0xff, I don't remember the specs saying anything about what the padding
> should contain.

I didn't say 'must' but 'AFAIK', because I could be wrong, but until proven
otherwise...

Anyway, there:
https://github.com/bbc/vc2hqencode/blob/master/vc2hqencode/serialise.hpp#L103
and I'd say it's authoritative?

Weird that a spec doesn't mandate a way to fill it, but maybe that's SMPTE.

For the rationale, no idea, maybe the coding of the zero coeff.


More information about the ffmpeg-devel mailing list