[FFmpeg-devel] [PATCH]lavf/webpenc: Do not set alpha flag for yuv420p

[Ronald S. Bultje]

Hi,

On Tue, May 3, 2016 at 3:22 PM, wm4 <nfxjfg at googlemail.com> wrote:

> On Tue, 3 May 2016 18:29:44 +0200
> Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>
> > On Tuesday 03 May 2016 06:11:59 pm Ronald S. Bultje wrote:
> > > Hi,
> > >
> > > On Tue, May 3, 2016 at 11:54 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
> wrote:
> > > > On Tuesday 03 May 2016 03:04:50 pm Ronald S. Bultje wrote:
> > > > > > +                if
> (av_pix_fmt_desc_get(st->codecpar->format)->flags
> > > > > > && AV_PIX_FMT_FLAG_ALPHA)
> > > > >
> > > > > I think you want s/&&/&/?
> > > >
> > > > Definitely, new patch attached.
> > >
> > > So, to address wm4's other concern, are there cases where
> > > st->codecpar->format is not set? E.g. codec copy or so?
>
> Just seems questionable that API users which mux and don't use most of
> ffmpeg's infrastructure directly would set the pixfmt for non-raw
> formats at all.
>
> > I have no idea but attached covers this case.
>
> Fine with me (although the coding style looks slightly strange).


I agree that coding style should be changed. Carl, can you please use the
more standard version of K&R? Most of our codebase uses this variant:

if (a ||
    b) {
    ..
}

instead of:

if (   a
    || b) {
    ..
}

I'm also OK with patch after that.

Ronald