[FFmpeg-devel] [PATCH] Add "sar" alias to "aspect" option of video encoders

[Michael Niedermayer]

On Mon, May 02, 2016 at 08:36:54PM +0300, Andrey Utkin wrote:
> It is impossible to pass "aspect" parameter to encoder from ffmpeg CLI
> because option from lavc/options_table.h is eclipsed by option with same
> name in ffmpeg_opt.c, which has different meaning (DAR, not SAR).
> ---
>  libavcodec/options_table.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h
> index d29996f..8efb889 100644
> --- a/libavcodec/options_table.h
> +++ b/libavcodec/options_table.h
> @@ -254,6 +254,7 @@ static const AVOption avcodec_options[] = {
>  {"median", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_PRED_MEDIAN }, INT_MIN, INT_MAX, V|E, "pred"},
>  #endif
>  {"aspect", "sample aspect ratio", OFFSET(sample_aspect_ratio), AV_OPT_TYPE_RATIONAL, {.dbl = 0}, 0, 10, V|E},
> +{"sar",    "sample aspect ratio", OFFSET(sample_aspect_ratio), AV_OPT_TYPE_RATIONAL, {.dbl = 0}, 0, 10, V|E},
>  {"debug", "print specific debug info", OFFSET(debug), AV_OPT_TYPE_FLAGS, {.i64 = DEFAULT }, 0, INT_MAX, V|A|S|E|D, "debug"},
>  {"pict", "picture info", 0, AV_OPT_TYPE_CONST, {.i64 = FF_DEBUG_PICT_INFO }, INT_MIN, INT_MAX, V|D, "debug"},
>  {"rc", "rate control", 0, AV_OPT_TYPE_CONST, {.i64 = FF_DEBUG_RC }, INT_MIN, INT_MAX, V|E, "debug"},

breaks fate / needs fate reference update
--- ./tests/ref/fate/api-png-codec-param        2016-05-01 12:29:43.726077137 +0200
+++ tests/data/fate/api-png-codec-param 2016-05-02 20:48:29.012527792 +0200
@@ -62,6 +62,7 @@
     bits_per_coded_sample=0
     pred=0
     aspect=2835/2835
+    sar=2835/2835
     debug=0x00000000
     vismv=0x00000000
     cmp=0
@@ -218,6 +219,7 @@
     bits_per_coded_sample=0
     pred=0
     aspect=2835/2835
+    sar=2835/2835
     debug=0x00000000
     vismv=0x00000000
     cmp=0

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160502/76dfb16d/attachment.sig>