[FFmpeg-devel] [PATCH] Implement hdcd filtering

[Michael Niedermayer]

On Tue, Mar 29, 2016 at 11:30:28AM +0200, Benjamin St wrote:
> > Not all of the comments on top of the filter file look
> > very useful to me, what do you think?
> > In any case, I'd say a link to these should be useful:
> > http://www.audiomisc.co.uk/HFN/HDCD/Enigma.html
> > http://www.audiomisc.co.uk/HFN/HDCD/Examined.html
> > (Or only the second one.)
> >
> I removed the rather useless comment and added both links.
> 
> Please also add a fate test, since this is using floats,
> > I would suggest to only compare pcm_s16 (instead of 24).
> 
> Floats are no longer needed. This version uses only integer.

>  Makefile     |    1 
>  af_hdcd.c    | 1138 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  allfilters.c |    1 
>  3 files changed, 1140 insertions(+)
> 4e25a0315a659eb9e71adfacb9f9b2e78c5e1f33  0001-Implement-high-definition-audio-cd-filtering.patch
> From f3053beac96884123e1c9d50b46876e6f69ae0d1 Mon Sep 17 00:00:00 2001
> From: Benjamin Steffes <benjaminst123 at gmail.com>
> Date: Mon, 21 Mar 2016 23:52:48 +0100
> Subject: [PATCH] Implement high definition audio cd filtering.
> 
> Signed-off-by: Benjamin Steffes <benjaminst123 at gmail.com>
> ---
>  libavfilter/Makefile     |    1 +
>  libavfilter/af_hdcd.c    | 1138 ++++++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/allfilters.c |    1 +
>  3 files changed, 1140 insertions(+)
>  create mode 100644 libavfilter/af_hdcd.c

fails make fate

--- ./tests/ref/fate/source     2016-03-28 20:55:31.220829289 +0200
+++ tests/data/fate/source      2016-03-29 23:51:43.338872226 +0200
@@ -8,6 +8,7 @@
 libavcodec/mathops.c
 libavcodec/reverse.c
 libavdevice/file_open.c
+libavfilter/af_hdcd.c
 libavfilter/log2_tab.c
 libavformat/file_open.c
 libavformat/golomb_tab.c
Test source failed. Look at tests/data/fate/source.err for details.
make: *** [fate-source] Error 1
make: *** Waiting for unfinished jobs....

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160330/bcf71744/attachment.sig>