[FFmpeg-devel] [PATCH]Addition of MLP encoder

[Michael Niedermayer]

On Sat, Mar 26, 2016 at 10:18:47PM +0530, Disha Singh wrote:
> This is the revised patch created using git format-patch.
> 
> -Disha
> 
> On Thu, Mar 24, 2016 at 2:45 PM, Paul B Mahol <onemda at gmail.com> wrote:
> 
> > On 3/21/16, Disha Singh <directionstar86 at gmail.com> wrote:
> > > Qualification task for project TrueHD encoder.
> > > There are two patches.
> > > One has the changes made to other files to support mlpenc.c and the other
> > > only has mlpenc.c.
> > > Also attached is the diff file of mlpenc.c.
> > > (Modified the file :
> > > https://github.com/ramiropolla/soc/blob/master/mlp/mlpenc.c)
> > >
> >
> > You need to make proper patch that can be applied to ffmpeg with no
> > separate files and strange patches.
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >

>  configure              |    1 
>  libavcodec/Makefile    |    1 
>  libavcodec/allcodecs.c |    2 
>  libavcodec/mlp.h       |    4 
>  libavcodec/mlpenc.c    | 2443 +++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 2450 insertions(+), 1 deletion(-)
> eac7dbd4d7bc0502d9fa09c13a6d5275114f3b83  0001-Mlp-encoder-addition.patch
> From 639aa2a07be6064049b2ba1e134e1474cb7f0806 Mon Sep 17 00:00:00 2001
> From: dinux5 <directionstar86 at gmail.com>
> Date: Sat, 26 Mar 2016 22:11:59 +0530
> Subject: [PATCH] Mlp encoder addition.

testing this
./ffmpeg -i in.m4a test.mlp
says it needs  'To use it anyways, you must set "-strict inofficial".'
thats ok if it would work:

./ffmpeg -i in.m4a -strict inofficial test.mlp
[mlp @ 0x2494740] Unable to parse option value "inofficial"

./ffmpeg -i in.m4a -strict -2 test.mlp
segfaults
Program received signal SIGSEGV, Segmentation fault.
0x0000000000aeed33 in determine_quant_step_size (ctx=0x20bf200) at libavcodec/mlpenc.c:1402
1402            dp->quant_step_size[channel] = number_trailing_zeroes(sample_mask[channel]) - mp->shift[channel];
(gdb) bt
Python Exception <type 'exceptions.ImportError'> No module named gdb.frames:
#0  0x0000000000aeed33 in determine_quant_step_size (ctx=0x20bf200) at libavcodec/mlpenc.c:1402
#1  0x0000000000af1434 in analyze_sample_buffer (ctx=0x20bf200) at libavcodec/mlpenc.c:2208
#2  0x0000000000af1dbe in mlp_encode_frame (avctx=0x20bdde0, avpkt=0x7fffffffdef0, frame=0x20bec20, got_packet_ptr=0x7fffffffdf5c) at libavcodec/mlpenc.c:2386
#3  0x0000000000cb179e in avcodec_encode_audio2 (avctx=0x20bdde0, avpkt=0x7fffffffdef0, frame=0x20bec20, got_packet_ptr=0x7fffffffdf5c) at libavcodec/utils.c:1826
#4  0x000000000042cd37 in do_audio_out (s=0x20a9b40, ost=0x20bdc00, frame=0x20bec20) at ffmpeg.c:815
#5  0x000000000042f5c5 in reap_filters (flush=0) at ffmpeg.c:1367
#6  0x000000000043c068 in transcode_step () at ffmpeg.c:4099
#7  0x000000000043c14c in transcode () at ffmpeg.c:4143
#8  0x000000000043c912 in main (argc=6, argv=0x7fffffffe448) at ffmpeg.c:4334

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160327/2c6426d1/attachment.sig>