[FFmpeg-devel] [PATCHv5 3/3] avformat/mov: read start_pad from edit list start time if codec is aac

Marton Balint cus at passwd.hu
Sun Mar 20 20:36:27 CET 2016


On Sat, 19 Mar 2016, Marton Balint wrote:

>
> On Mon, 14 Mar 2016, Marton Balint wrote:
>
>> On Sun, 13 Mar 2016, Marton Balint wrote:
>>
>>> Related to ticket #2324, #2325.
>>>
>>> Stream duration still need to be fixed...
>>>
>>> Signed-off-by: Marton Balint <cus at passwd.hu>
>>> ---
>>> libavformat/mov.c                            | 3 +++
>>> tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 8 ++++----
>>> tests/ref/fate/gaplessenc-pcm-to-mov-aac     | 8 ++++----
>>> 3 files changed, 11 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/libavformat/mov.c b/libavformat/mov.c
>>> index 4f446ba..3fa8fcc 100644
>>> --- a/libavformat/mov.c
>>> +++ b/libavformat/mov.c
>>> @@ -2688,6 +2688,9 @@ static void mov_build_index(MOVContext *mov, 
> AVStream 
>> *st)
>>>                 st->codec->has_b_frames = 1;
>>>             }
>>>         }
>>> +
>>> +        if (!unsupported && st->codec->codec_id == AV_CODEC_ID_AAC && 
>> start_time > 0)
>>> +            sc->start_pad = start_time;
>>
>> I wonder if sc->time_offset might be better here, instead of start_time.
>
> Okay, I checked the ISO docs, and start_time is fine as far as I 
> understand it.
>
> I will apply the patch series soon.
>

Applied the series.

Regards,
Marton


More information about the ffmpeg-devel mailing list