[FFmpeg-devel] [PATCH 1/2] lavc: add AudioToolbox decoders

[Thilo Borgmann]

Am 01.03.16 um 10:49 schrieb Rodger Combs:
> [...]
>  External library support:
> +  --disable-audiotoolbox   enable AudioToolbox decoders and encoders [autodetect]

Do we consider platform codecs external libraries?


> [...]
> +    ret = AudioConverterFillComplexBuffer(at->converter, ffat_decode_callback, avctx,
> +                                          &frame->nb_samples, &out_buffers, NULL);
> +    if ((!ret || ret == 1) && frame->nb_samples) {
> +        *got_frame_ptr = 1;
> +        if (at->last_pts != AV_NOPTS_VALUE) {
> +            frame->pts = at->last_pts;
> +            at->last_pts = avpkt->pts;
> +        }
> +    } else if (ret && ret != 1) {

> +        av_log(avctx, AV_LOG_WARNING, "Decode error: %i\n", ret);

Something useful should be printed here and for all other warnings/errors.
This should be changed for the encoders patch as well.

LGTM Otherwise.

-Thilo