[FFmpeg-devel] [PATCH] Use lowercase includes and library names for schannel check

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Mar 15 20:26:09 CET 2016


On Tue, Mar 08, 2016 at 02:48:04PM +0200, Ismail Donmez wrote:
> This fixes cross-build on Linux with mingw-w64. Patch attached. This
> will not break MSVC because Windows is case-insensitive unlike Linux.
> 
> Please review.

I see this:
libavformat/tls_schannel.c:#include <security.h>
libavformat/tls_securetransport.c:#include <Security/Security.h>

Are those different headers?
Because if those are all the some one, they
should be fixed to be consistent.
Apart from that, the configure check definitely
should use exact same spelling as the actual file,
anything else is a bug.
And for consistency I'd prefer all-lowercase regardless
of mingw compatibility, so I have no objections in
principle.


More information about the ffmpeg-devel mailing list