[FFmpeg-devel] [PATCH] lavc/parser: export resolution and format in AVCodecContext if not already set

[Michael Niedermayer]

On Tue, Mar 15, 2016 at 06:49:18PM +0100, Marton Balint wrote:
> On Tue, 15 Mar 2016, Rodger Combs wrote:
> 
> >This allows avformat_find_stream_info to finish without opening a decoder in
> >more cases.
> 
> That may be a good thing, but it still removes existing
> functionality. Would it be too much work to introduce
> avformat_find_stream_info2 with an additional flags parameter where
> the user can set if he wants the code to open a decoder to get
> additional information?

a flag settable through AVOptions would be more flexible (could be
set for any tool that supports AVOptions)
and also would avoid another whatever2() function


> 
> >
> >Since decoders still export some information that the corresponding parsers
> >don't, this causes some fields to be unset in ffprobe output where the
> >decoder would previously have only been called in avformat_find_stream_info.
> >If this is a problem, the parsers should be updated to report that information
> >as well.
> 
> Have you checked how "widespread" is this problem? E.g. how many
> previously known values will not be present in ffprobe -show_streams
> output if you run it to our sample corpus? If it is more than a few
> cases, (so fixing the parses is not a reasonable amount of work)
> then we shouldn't just break the output of ffprobe, but figure out
> something to keep it as full of information as possible.
> 
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160315/0672c960/attachment.sig>