[FFmpeg-devel] [PATCH 0/4] DCA decoder fixes

James Almer jamrial at gmail.com
Wed Mar 2 22:53:45 CET 2016


On 3/2/2016 4:30 PM, foo86 wrote:
> This fixes some potential issues I've identified within new DCA decoder. It is
> probably a good idea to backport these patches into 3.0 release branch.
> 
> foo86 (4):
>   avcodec/dca: clear X96 channels if nothing was decoded
>   avcodec/dca: fix av_cold placement in declarations
>   avcodec/dca: simplify condition
>   avcodec/dca: make reading past end of buffer safe
> 
>  libavcodec/dca_core.c |  1 +
>  libavcodec/dca_xll.c  | 46 +++++++++++++++++++++++-----------------------
>  libavcodec/dcadec.h   |  2 +-
>  3 files changed, 25 insertions(+), 24 deletions(-)

Nice, thanks.
While at it, could you check if https://ffmpeg.org/pipermail/ffmpeg-devel/2016-January/188319.html
was the proper workaround to get https://trac.ffmpeg.org/raw-attachment/ticket/3550/WorstCase.wav
working, or if it needs some changes similar to the ones in patch 4/4 from this set?
Also, send a patch to add yourself as maintainer of the decoder in the MAINTAINERS file. You should
also ask Michael (i think) to get push access to the git repo.


More information about the ffmpeg-devel mailing list