[FFmpeg-devel] [PATCH] avfilter/vf_rotate: add >8 bit depth support

[Muhammad Faiz]

On Sun, Jun 26, 2016 at 4:20 PM, Muhammad Faiz <mfcc64 at gmail.com> wrote:
> On Sun, Jun 26, 2016 at 3:22 PM, Paul B Mahol <onemda at gmail.com> wrote:
>> On 6/26/16, Muhammad Faiz <mfcc64 at gmail.com> wrote:
>>> On Sun, Jun 26, 2016 at 2:30 PM, Paul B Mahol <onemda at gmail.com> wrote:
>>>> On 6/26/16, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>>>>> Muhammad Faiz <mfcc64 <at> gmail.com> writes:
>>>>>
>>>>>> I think it's not because of bit-exact problem.
>>>>>> But because fate probes supported formats (with
>>>>>> libavfilter/tests/filtfmts)
>>>>>> On BE machine, code with native formats will generate error
>>>>>> because fate-ref contains yuv*le entries but fate expects yuv*be
>>>
>>> Another problem is that drawutils only support LE format.
>>>
>>>>>
>>>>> We control the fate test, so we can require an additional
>>>>> (bit-exact) conversion from BE to LE to make the fate
>>>>> test pass.
>>>>
>>>> Really, even for pixfmts?
>>>>
>>>> I will apply this as is. Feel free to add your hacks if you want, after.
>>>
>>> In the perspective of code correctness, this should be OK.
>>> But performance on BE machine will be unoptimal because:
>>>  - reading/writing in foreign endian is probably slower
>>>  - I guess most decoders' output frame is native endian. This will
>>>    make unnecessary format conversion
>>>  - some other filters only support native endian formats. This will
>>>    also make unnecessary format conversion.
>>>
>>> Of course, the problem is not in your patch.
>>
>> Yes. BE is dead.
>
> The problem is in drawutils. I think, it should support native endian
> or support both little/big endian.
>
> Thank's

See https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2016-June/195930.html

Thank's